You didn't give any pro or con about your repair. If they can do that and pop in a fresh battery then you may get a year or two more from this phone. What's not to like?
For me, at the office we develop on Android (and other things/oses) so for us we rarely carry an old model..
That said I carry 2 phones. A Moto G 5th gen and my old iPhone 5s with it's Jackery battery case.
My son picked up a new BLU Vivo XL3 -5.5” HD+ 18:9 Display Smartphone with Android 8.0 Oreo. Why? Only 129.99USD and it has the current OS, 3GB RAM yada yada. Will recommend if someone is shopping cheap.
Should i repair my s6 edge camera, or get a new phone? The repair would cost 70e and if i get a new phone it most likely would be galaxy s8 or huawei p20 lite