Yes and no. Essentially, the technician you're talking to is full of crap and you should take your business elsewhere.
If there is driver support for a given bit of hardware for an OS, that's the end of the story. I'm not sure where they were coming up with this nonsense about limiting the number of CPU cores and all of that either. There are a few, very specific, instances where you may want to do that, but not as a general rule certainly.
The stability problems you're encountering could be the result of any number of things, but not because of any particular age of the OS. As I said, as long as there are drivers for the hardware for that specific OS, that's all the more you need. It can certainly happen that you'll find hardware being made these days in which the manufacturer never bothered to make XP drivers. So in that case, XP would indeed be too old for the hardware. There's nothing really stopping them from making XP drivers if they wanted, but the XP market share is basically stagnant or declining and Microsoft is trying to push people off of that platform as fast as possible, so it doesn't make a lot of sense to spend a lot of resources developing XP drivers for newer hardware.
If the same technician who has been feeding you all of this utter nonsense is the same one who built your PC, I'd be inclined to think they just picked cheap/shoddy parts because they didn't know what they were doing. It's entirely possible they screwed something else up. If you've been taking this PC to the same person every time it's had an issue, I'd say it's time to get a second opinion. Until you know for sure what you have is fundamentally a software issue, upgrading to Windows 7 could just make matters even worse. Take the unit somewhere else to get a fresh set of eyes on it and see what that turns up because to put it rather bluntly, the one technician has been blowing a whole lot of smoke up your ****.
I was one of the number of users who stuck with Windows XP when Windows Vista came out, and I still run that Operating System on my PC today.
But some time ago (a little less than 2 years ago) I gave my PC a near-complete hardware upgrade (about 90%, I replaced everything but the secondary hard drive), New Ram, New Motherboard, Processor, Power Supply and when I did that, the Technician who put the hardware in, got the drivers and Operating System set up, told me that I should refrain from further hardware upgrades, as it's getting to a point where Windows XP will not be able to run the hardware, even with the drivers, and also advised against unlocking all four of the processing cores, so for a long time, I ran on two processing cores instead of all fours, but not too long ago, it came to be that my PC had to be wiped, and being a 2D Artist and Graphic Designer who had obligations to meet, it had to be done quickly. When I powered on the computer the next time, it showed me all four cores were unlocked, I was still able to get into Windows and use the programs I often used before, but stability problems soon started arising, Programs would freeze, Windows wouldn't always read input such as mouse clicks, small to medium inconveniences. When my PC developed display problems, and I brought my tower into the shop, everything checked out physically, my two hard drives were given the all clear; my RAM, Motherboard and Power supply were not mentioned as factors, the problem was discovered to be unrelated to the tower, as I no longer have display issues after replacing the monitor.
But the stability problems remain, even after a wipe and a fresh install of Windows XP. We're all aware of people who get an Operating System that's too old for the hardware they run, but is it possible for the reverse to occur? That the Operating System I'm using is too old for the hardware I run and that an upgrade to Windows 7 will resolve this, or was the technician who installed my hardware out to lunch when he suggested this as a factor?
Hoping for a conclusive opinion
-Hannah

Chowhound
Comic Vine
GameFAQs
GameSpot
Giant Bomb
TechRepublic